[PATCH] D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj.

[EsmeYi via Phabricator via llvm-commits]

Esme added inline comments.


================
Comment at: llvm/lib/ObjectYAML/XCOFFEmitter.cpp:67
+      if (CurrentOffset > MaxRawDataSize) {
+        ErrHandler("the maximum size permitted for relocation data is " +
+                   Twine(MaxRawDataSize));
----------------
jhenderson wrote:
> Sorry, I might have confused you with my previous comment. `MaxRawDataSize` is being compared to `CurrentOffset`, so it's not the size of the relocations/sections that is being constrained, if I read it correctly. Perhaps you could change the message to something like "maximum object size of XXX exceeded when writing relocation data". What do you think?
Very good suggestion, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95505/new/

https://reviews.llvm.org/D95505