[PATCH] D99423: [DebugInfo] Fix incorrect updating of SDNode dependencies for variadic debug values

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:1354
         // Both describe the direct values of their associated variables.
+        Dependencies.push_back(N.getNode());
         LocationOps.emplace_back(SDDbgOperand::fromFrameIdx(FISDN->getIndex()));
----------------
djtodoro wrote:
> so this is relevant for stack objects only?
Correct; when calculating dependencies for an SDDbgValue, this patch will automatically include any SDNodes that are used directly as operands, so we no longer need to add (and should not add) the SDNodes as dependencies for every argument; because frame index operands do not hold a direct reference the SDNode they depend on, we manually add it for those operands and only those operands.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99423/new/

https://reviews.llvm.org/D99423