[PATCH] D99423: [DebugInfo] Fix incorrect updating of SDNode dependencies for variadic debug values

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 29 02:24:33 PDT 2021


djtodoro added a comment.

LGTM overall (as @jmorse pointed out, if possible, I'd like to see a test case)



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:1354
         // Both describe the direct values of their associated variables.
+        Dependencies.push_back(N.getNode());
         LocationOps.emplace_back(SDDbgOperand::fromFrameIdx(FISDN->getIndex()));
----------------
so this is relevant for stack objects only?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99423/new/

https://reviews.llvm.org/D99423



More information about the llvm-commits mailing list