[PATCH] D99429: [AMDGPU] Save WWM registers in functions

Carl Ritson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 28 20:24:17 PDT 2021


critson added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h:464
 
-  SparseBitVector<> WWMReservedRegs;
-
-  void ReserveWWMRegister(Register Reg) { WWMReservedRegs.set(Reg); }
+  SmallVector<SGPRSpillVGPRCSR> WWMReservedRegs;
 
----------------
I wonder if SmallSetVector would be more appropriate, as it would save you iterating this to check if a given register is reserved.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99429/new/

https://reviews.llvm.org/D99429



More information about the llvm-commits mailing list