[PATCH] D99429: [AMDGPU] Save WWM registers in functions

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 28 08:01:18 PDT 2021


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:725
+    auto SpillMI = MBBI;
+    TII->getNamedOperand(*(--SpillMI), AMDGPU::OpName::flags)->setImm(1);
+  }
----------------
I'm not sure what this is setting (I'm also not a huge fan of stepping the iterator back to find the inserted instruction since it spreads the assumption that this only inserts one instruction)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99429/new/

https://reviews.llvm.org/D99429



More information about the llvm-commits mailing list