[PATCH] D99376: [AMDGPU] Mark additional VOP3 as commutable

[Joe Nash via Phabricator via llvm-commits]

Joe_Nash marked 3 inline comments as done.
Joe_Nash added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/VOP3Instructions.td:644
+  defm V_ADD_I32 : VOP3Inst <"v_add_i32", VOP3_Profile<VOP_I32_I32_I32_ARITH>>;
+  defm V_SUB_I32 : VOP3Inst <"v_sub_i32", VOP3_Profile<VOP_I32_I32_I32_ARITH>>;
+} // End isCommutable = 1
----------------
rampitec wrote:
> foad wrote:
> > Subtraction is not commutative!
> It is commutative since there is subrev, but it needs to define Commutable_REV<> which it does not.
Going to leave it as not commutative for now, since no VOP3 handle Commutable_REV<> at the moment


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99376/new/

https://reviews.llvm.org/D99376