[PATCH] D99376: [AMDGPU] Mark additional VOP3 as commutable

Joe Nash via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 26 14:39:26 PDT 2021


Joe_Nash updated this revision to Diff 333635.
Joe_Nash added a comment.

remove sub as commutative and add add_lshl.
Its pretty bizarre to me that no testing cared if sub was commutative.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99376/new/

https://reviews.llvm.org/D99376

Files:
  llvm/lib/Target/AMDGPU/VOP3Instructions.td
  llvm/test/CodeGen/AMDGPU/GlobalISel/fshl.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/fshr.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.image.atomic.dim.a16.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.image.gather4.a16.dim.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.image.sample.ltolz.a16.ll
  llvm/test/CodeGen/AMDGPU/commute-vop3.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99376.333635.patch
Type: text/x-patch
Size: 22268 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210326/93da5ba1/attachment.bin>


More information about the llvm-commits mailing list