[PATCH] D99384: [AArch64] Avoid SCALAR_TO_VECTOR for single FP constant vector.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:9673
   SDValue ConstantValue;
+  auto IsIntOrFPConstant = [](SDValue V) {
+    return isa<ConstantSDNode>(V) || isa<ConstantFPSDNode>(V);
----------------
david-arm wrote:
> It's just a thought, but this looks like a useful static function in it's own right that could live in a header somewhere? There are other parts of codegen that check the same thing, i.e.
> 
>   DAGCombiner::visitBITCAST
>   DAGCombiner::getStoreMergeCandidates
> 
That's a great idea, thanks! I put up D99384


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99384/new/

https://reviews.llvm.org/D99384