[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 26 09:57:39 PDT 2021


aganea added a comment.

I'm just wondering if D96363 <https://reviews.llvm.org/D96363> and all attached subsequent patches shouldn't be reverted for now. This is quite trivial case uncovered by tests. On re-land, I would then add a test validating the issue on Windows:

  $ cat -A rewrite-includes-clang-cl.cpp
  // REQUIRES: windows^M$
  // RUN: %clang_cl /E -Xclang -frewrite-includes %s | %clang_cl /c /clang:-verify /Tp -^M$
  // expected-no-diagnostics^M$
  ^M$
  int foo();^M$
  int bar();^M$
  #define HELLO \^M$
    foo(); \^M$
    bar();^M$
  ^M$
  int main() {^M$
    HELLO^M$
    return 0;^M$
  }^M$


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99363/new/

https://reviews.llvm.org/D99363



More information about the llvm-commits mailing list