[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

Fri Mar 26 09:49:39 PDT 2021

aganea added a comment.

In D99363#2652907 <https://reviews.llvm.org/D99363#2652907>, @abhina.sreeskantharajan wrote:

> In D99363#2652899 <https://reviews.llvm.org/D99363#2652899>, @aganea wrote:
>
>> Sorry, but after this patch, I still see the issue mentioned in https://reviews.llvm.org/D96363#2650460
>> @abhina.sreeskantharajan are you able to confirm the issue on your end?
>
> I don't have a Windows machine to test on, but I assumed since the problem was in rewrite then this patch should have fixed it. Would you be able to confirm if reverting the change in clang/lib/Driver/Driver.cpp fixes the problem for you?

I went back to the version on the left:
F16001158: image.png <https://reviews.llvm.org/F16001158>
but that does not fix the problem.

Indeed, I've tested & the problem does not occur on Linux.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99363/new/

https://reviews.llvm.org/D99363