[PATCH] D99380: [llvm][hwasan] Add Fuchsia shadow mapping configuration
    Roland McGrath via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Mar 25 15:16:04 PDT 2021
    
    
  
mcgrathr accepted this revision.
mcgrathr added a comment.
lgtm with comment added
================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:1537
+    InTls = false;
+    Offset = 0;
+  } else if (ClMappingOffset.getNumOccurrences() > 0) {
----------------
phosek wrote:
> It may be worth leaving the same comment as we have for ASan: https://github.com/llvm/llvm-project/blob/4b5baa5b8244778b0e7253cdb98924c3dab611b7/llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp#L488
agreed
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99380/new/
https://reviews.llvm.org/D99380
    
    
More information about the llvm-commits
mailing list