[PATCH] D99380: [llvm][hwasan] Add Fuchsia shadow mapping configuration

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 25 14:41:02 PDT 2021


phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:1537
+    InTls = false;
+    Offset = 0;
+  } else if (ClMappingOffset.getNumOccurrences() > 0) {
----------------
It may be worth leaving the same comment as we have for ASan: https://github.com/llvm/llvm-project/blob/4b5baa5b8244778b0e7253cdb98924c3dab611b7/llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp#L488


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99380/new/

https://reviews.llvm.org/D99380



More information about the llvm-commits mailing list