[PATCH] D99273: [DebugInfo] Support for signed constants inside DIExpression

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX added inline comments.


================
Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:2587
+  /// Determine whether this represents a standalone unsigned constant value.
+  bool isUnsignedConstant() const;
 
----------------
These functions can be cascaded/merged into `isConstant` function body(with multiple if statements). However keeping them orthogonal/independent has advantages of it's own.
One motivating example can be seen at `llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:217` where this function call fulfill the intent of conveying the necessary info i.e `signed` or `unsigned`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99273/new/

https://reviews.llvm.org/D99273