[PATCH] D99273: [DebugInfo] Support for signed constants inside DIExpression

Sourabh Singh Tomar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 25 00:22:27 PDT 2021


SouraVX updated this revision to Diff 333222.
SouraVX added a comment.

Changes:

- Rebased to tip.
- Addressed @dstenb review comments regarding covering fragments and added test case to excercise that.
- Addressed @aprantl review comments of combinining check to a single function i.e `isConstant`.
- Replaced most checks of `isUnsignedConstant` with `isConstant` adding appropriate test case modifications to exercise the changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99273/new/

https://reviews.llvm.org/D99273

Files:
  llvm/include/llvm/IR/DebugInfoMetadata.h
  llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
  llvm/lib/IR/DebugInfoMetadata.cpp
  llvm/test/DebugInfo/X86/global-constants.ll
  llvm/test/DebugInfo/X86/stack-value-dwarf4.ll
  llvm/test/Transforms/StripSymbols/strip-dead-debug-info.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99273.333222.patch
Type: text/x-patch
Size: 9676 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210325/39ff8d81/attachment.bin>


More information about the llvm-commits mailing list