[PATCH] D99212: [Support] Fix Windows 7 path handling

Wed Mar 24 07:04:32 PDT 2021

rdwampler added inline comments.

================
Comment at: llvm/lib/Support/Windows/Path.inc:408
+  // When Delete is false skip the check, since on Windows 7 the function
+  // realPathFromHandle() below would fail. In that case, network files would
+  // also get the 'false' flag, but that is fine.
----------------
aganea wrote:
> rdwampler wrote:
> > IIUC, realPathFromHandle() fails because FILE_DISPOSITION_INFO is already set to true, if so can you update the comment here to clarify. I think this would still fail if setDeleteDisposition() is called twice with Delete being true.
> Changed as suggested. Please let me know if the wording isn't correct of it doesn't fully capture the issue.
Thanks, LGTM.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99212/new/

https://reviews.llvm.org/D99212