[PATCH] D99212: [Support] Fix Windows 7 path handling

Wed Mar 24 07:02:12 PDT 2021

jhenderson added a comment.

In D99212#2647555 <https://reviews.llvm.org/D99212#2647555>, @aganea wrote:

> In D99212#2646852 <https://reviews.llvm.org/D99212#2646852>, @jhenderson wrote:
>
>> Looks reasonable to me. I guess this means that on Windows 7 we might end up with temp files kicking around afterwards?
>
> There's no behavior specific to Windows 7, only this workaround to ensure the code works on both systems (Win 7 & 10). Temp files will remain on disk only if we're writing to a network drive, and only if the target file isn't renamed.

Yep, got it (I realised there wasn't anything Windows 7 specific here before that point). Not all temp files will be renamed though. Is it worth some additional commenting somewhere to make this clear?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99212/new/

https://reviews.llvm.org/D99212