[PATCH] D99029: [RISCV] Don't form MULW for (sext_inreg (mul X, Y), i32)) if the mul has another use.

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 24 02:48:42 PDT 2021


frasercrmck added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoM.td:74
+// A 'mul' node with a single use.
+def mul_su : PatFrag<(ops node:$lhs, node:$rhs), (mul node:$lhs, node:$rhs), [{
+  return N->hasOneUse();
----------------
Super nitty, but I see `su` and my mind doesn't jump to "single use". I think more "signed/unsigned". Maybe something like `mul_oneuse`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99029/new/

https://reviews.llvm.org/D99029



More information about the llvm-commits mailing list