[PATCH] D99055: [llvm-objcopy][NFC] remove processing of ELF specific options from common CopyConfig structure.
Alexey Lapshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 23 14:59:19 PDT 2021
avl added a comment.
Looking at the design for ELF parseable options more, I do not really understand why parsing of ELF options should be delayed. It seems that they might be set at the same time when all other options parsed(i.e. as it was before D67139 <https://reviews.llvm.org/D67139>):
remove
std::vector<StringRef> SymbolsToAdd;
Optional<StringRef> NewSymbolVisibility
from CopyConfig. So that CopyConfig never contains unparsed strings.
add specific ELF fields to CopyConfig:
CopyConfig {
// ELF specific options.
Optional<uint8_t> NewSymbolVisibility;
std::vector<NewSymbolInfo> SymbolsToAdd;
}
parseObjcopyOptions() {
// set NewSymbolVisibility and SymbolsToAdd
// if corresponding options exist in arguments.
}
What do you think?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99055/new/
https://reviews.llvm.org/D99055
More information about the llvm-commits
mailing list