[PATCH] D99055: [llvm-objcopy][NFC] remove processing of ELF specific options from common CopyConfig structure.

[Alexey Lapshin via Phabricator via llvm-commits]

avl updated this revision to Diff 332586.
avl added a comment.

addressed comments:

Restored ELFConfig.h/cpp as a separate file keeping options parsing code.
Left usage of parsing code of elf-specific options inside /ELF directory.

D67139 <https://reviews.llvm.org/D67139> suggested parsing specific options lazily.
i.e. To parse them only in case when they are necessary.
But it places format-specific options in a common CopyConfig structure.
This does not look good since all users of ELFConfig are inside of
/ELF directory(Thus we do not need to make them visible to others).
This patch hides elf-specific processing inside /ELF directory
and parses format-specific options lazily.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99055/new/

https://reviews.llvm.org/D99055

Files:
  llvm/tools/llvm-objcopy/CopyConfig.h
  llvm/tools/llvm-objcopy/ELF/ELFConfig.cpp
  llvm/tools/llvm-objcopy/ELF/ELFConfig.h
  llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp
  llvm/tools/llvm-objcopy/llvm-objcopy.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99055.332586.patch
Type: text/x-patch
Size: 7522 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210323/08cb77c6/attachment.bin>