[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

[Paulo Matos via Phabricator via llvm-commits]

pmatos added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1330
+
+  // Expect Offset to be undef for externref stores
+  const SDValue &Offset = SN->getOffset();
----------------
wingo wrote:
> What is an externref store?  A store of an externref value?
That should say `externref global stores`.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyUtilities.cpp:110
     Sym->setFunctionTable();
     // The default function table is synthesized by the linker.
     Sym->setUndefined();
----------------
wingo wrote:
> This would not be the case for the call_ref table, right?  Rather it would have fixed size 1 and be defined as comdat.
I refactored that. Comdat is being set in `getOrCreateFuncrefCallTableSymbol`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95425/new/

https://reviews.llvm.org/D95425