[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

Tue Mar 23 01:14:50 PDT 2021

pmatos added a comment.

In D95425#2643730 <https://reviews.llvm.org/D95425#2643730>, @lebedev.ri wrote:

> Once again, are the changes to the LLVM IR (LLVMTypeKind & friends) actually needed?
> I'm not seeing any usages of that in the tests.

Hi, I was going refer to those in a separate comment. My apologies for the delay.
Those were required to get this to work due to a call in SelectionDAGBuilder.cpp (current like 9966) to `VT.getTypeForEVT`. This requires me to create a type for the EVT `externref` and `funcref`. This forced the change to `ValueTypes.cpp`.  Once you create the Type for `externref` and `funcref` the other changes come along either by necessity or to avoid warnings that certain cases were not handled in switches.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95425/new/

https://reviews.llvm.org/D95425