[PATCH] D98861: [CMAKE] Fix cross-compilation build

Vladislav Vinogradov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 23 01:39:40 PDT 2021


vinograd47 marked 3 inline comments as done.
vinograd47 added inline comments.


================
Comment at: llvm/CMakeLists.txt:762
 
+if(LLVM_INCLUDE_TESTS)
+  include(GetErrcMessages)
----------------
jhenderson wrote:
> Thanks for moving. That being said, on further review, why isn't this where it was before (I assume there's a good reason for it)?
> 
> Also, perhaps you could add a comment so that users don't have to go digging to understand why this if is necessary etc.
I've moved this lines, because `LLVM_INCLUDE_TESTS` variable was defined below. I'm not sure about this comment. This `if` is not necessary, it is vice versa, the `get_errc_messages` call is needed for tests only.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98861/new/

https://reviews.llvm.org/D98861



More information about the llvm-commits mailing list