[PATCH] D98861: [CMAKE] Fix cross-compilation build
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 23 01:33:57 PDT 2021
jhenderson added inline comments.
================
Comment at: llvm/CMakeLists.txt:762
+if(LLVM_INCLUDE_TESTS)
+ include(GetErrcMessages)
----------------
Thanks for moving. That being said, on further review, why isn't this where it was before (I assume there's a good reason for it)?
Also, perhaps you could add a comment so that users don't have to go digging to understand why this if is necessary etc.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98861/new/
https://reviews.llvm.org/D98861
More information about the llvm-commits
mailing list