[PATCH] D99057: [TableGen] Allow BitsInit to init integer in pseudo expansion

[Paul C. Anagnostopoulos via Phabricator via llvm-commits]

Paul-C-Anagnostopoulos added inline comments.


================
Comment at: llvm/utils/TableGen/PseudoLoweringEmitter.cpp:111
       ++OpsAdded;
+    } else if (auto BI = dyn_cast<BitsInit>(Dag->getArg(i))) {
+      auto II = dyn_cast<IntInit>(BI->convertInitializerTo(IntRecTy::get()));
----------------
I would declare BI as BitsInit *BI, for consistency.


================
Comment at: llvm/utils/TableGen/PseudoLoweringEmitter.cpp:113
+      auto II = dyn_cast<IntInit>(BI->convertInitializerTo(IntRecTy::get()));
+      assert(II);
+      OperandMap[BaseIdx + i].Kind = OpData::Imm;
----------------
Please include a message in the assert, in the usual way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99057/new/

https://reviews.llvm.org/D99057