[PATCH] D97039: [PowerPC] Enable redundant TOC save removal on AIX

Qiu Chaofan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 21 23:30:24 PDT 2021


qiucf marked an inline comment as done.
qiucf added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/remove-redundant-toc-saves.ll:65
+; AIX32-LABEL: test3:
+; AIX32-COUNT-3: stw 2, 20(1)
 entry:
----------------
shchenz wrote:
> This should be out of this patch's scope, but we should have the opportunity to common TOCSave in block `if.then` and `if.else` to their common dominator block `entry`. Then we should only have one TOCSave in the final assembly.
Thanks for pointing this out. Yes, that's a point for future improvement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97039/new/

https://reviews.llvm.org/D97039



More information about the llvm-commits mailing list