[PATCH] D97039: [PowerPC] Enable redundant TOC save removal on AIX

Wed Mar 17 23:41:32 PDT 2021

shchenz accepted this revision.
shchenz added a comment.
This revision is now accepted and ready to land.

LGTM with one minor comment and one idea about further improvement. Thanks for improving this.

================
Comment at: llvm/test/CodeGen/PowerPC/remove-redundant-toc-saves.ll:2
 ; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu < %s | FileCheck %s
+; RUN: llc -verify-machineinstrs -mtriple=powerpc64-ibm-aix-xcoff < %s | FileCheck %s --check-prefix=AIX
+; RUN: llc -verify-machineinstrs -mtriple=powerpc-ibm-aix-xcoff < %s | FileCheck %s --check-prefix=AIX32
----------------
Maybe it's better to use AIX64 as prefix comparing with below AIX32?

================
Comment at: llvm/test/CodeGen/PowerPC/remove-redundant-toc-saves.ll:65
+; AIX32-LABEL: test3:
+; AIX32-COUNT-3: stw 2, 20(1)
 entry:
----------------
This should be out of this patch's scope, but we should have the opportunity to common TOCSave in block `if.then` and `if.else` to their common dominator block `entry`. Then we should only have one TOCSave in the final assembly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97039/new/

https://reviews.llvm.org/D97039