[PATCH] D98967: [Analysis]Add getPointersDiff function to improve compile time.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 21 06:22:10 PDT 2021


spatel added inline comments.


================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:1137-1138
+  // Make sure that A and B are different pointers.
+  if (PtrA == PtrB)
+    return 0;
+
----------------
Drive-by comment: should this be the first thing we check? Is it valid for callers to pass in null values for one or both of these arguments, or can we assert that it should not happen?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98967/new/

https://reviews.llvm.org/D98967



More information about the llvm-commits mailing list