[PATCH] D98845: [X86] Fix a bug when calculating the ldtilecfg insertion points.

Pengfei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 19 23:26:47 PDT 2021


pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:303
+  // hoist the first tile config point out of the loop in future.
+  BBVisitedInfo[MBB].HasCallBeforeAMX = true;
+
----------------
LuoYuanke wrote:
> It take the some time to re-understand what HasCallBeforeAMX means. It seems NoPredUpdate is more readable than HasCallBeforeAMX, but it is not related to this patch.
Good suggestion. I refactored it bassed on your thought by D99010.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98845/new/

https://reviews.llvm.org/D98845



More information about the llvm-commits mailing list