[PATCH] D98929: Add missing cases in RISCVMCExpr::getVariantKindName
Serge Pavlov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 19 10:45:26 PDT 2021
sepavloff added a comment.
In D98929#2637766 <https://reviews.llvm.org/D98929#2637766>, @craig.topper wrote:
> Is it possible to test this?
I do not know how to test this. But I changed the patch so that if a new item would be added to `VariantKind` and that item would not be handled in the switch statement, compilation would give a warning.
In D98929#2637769 <https://reviews.llvm.org/D98929#2637769>, @jrtc27 wrote:
> I think these are just for debug output? Though maybe they appear in MIR too?
I got crash when executed `llc -debug -filetype=obj`. I am not sure if it can be found in MIR, but this looks unlikely, as it is an MC layer feature.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98929/new/
https://reviews.llvm.org/D98929
More information about the llvm-commits
mailing list