[PATCH] D98929: Add missing cases in RISCVMCExpr::getVariantKindName

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 19 10:42:50 PDT 2021


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVMCExpr.cpp:177
   }
+  return StringRef();
 }
----------------
Can this just be llvm_unreachable and then you wouldn't need the first assert?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98929/new/

https://reviews.llvm.org/D98929



More information about the llvm-commits mailing list