[PATCH] D98936: [RISCV] DAG nodes and pseudo instructions for CSR access

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 19 04:46:57 PDT 2021


jrtc27 added a comment.

CSR addresses are uimm12s not simm12s



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.h:236
+  // the value read before the modification and the new chain pointer.
+  MODIFY_CSR,
+
----------------
Hm, modify isn't a great name when WRITE_CSR exists


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98936/new/

https://reviews.llvm.org/D98936



More information about the llvm-commits mailing list