[PATCH] D98803: [llvm-symbolizer][llvm-nm] Fix AArch64 and ARM mapping symbols handling.

[Yvan Roux via Phabricator via llvm-commits]

yroux added a comment.

Hmm, there is tools/llvm-nm/debug-syms.test which tests ARM --special-syms and --debug-syms, notice that with this change --special-syms is no more needed to dump mapping-symbols when --debug-syms is used, which is now in sync with gnu binutils nm.  I don't see an AArch64 test though



================
Comment at: llvm/test/DebugInfo/Symbolize/ELF/aarch64-mapping-symbol.s:8-11
+    .word 32
+    nop
+    nop
+    .word 42
----------------
jhenderson wrote:
> It might be helpful to illustrate with an llvm-nm execution where the $d and $x appear, to help validate the test. At the moment, this test simply shows that foo is used for values 0 and 4.
I agree, I'll also add one to the existing arm version of this test 


================
Comment at: llvm/test/tools/llvm-nm/ARM/special-syms.test:1
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-nm %t | count 0
----------------
jhenderson wrote:
> Add a comment to the top of this test explaining what symbols are considered special for ARM.
> 
> Do you need an AARCH64 version of this test?
I'll add a comment which describes the test.

AArch64 version already exists under llvm-nm/AArch64 directory


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98803/new/

https://reviews.llvm.org/D98803