[PATCH] D98803: [llvm-symbolizer][llvm-nm] Fix AArch64 and ARM mapping symbols handling.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I assume there's already test coverage for --debug-syms with ARM and AARCH64 symbols?



================
Comment at: llvm/test/DebugInfo/Symbolize/ELF/aarch64-mapping-symbol.s:8-11
+    .word 32
+    nop
+    nop
+    .word 42
----------------
It might be helpful to illustrate with an llvm-nm execution where the $d and $x appear, to help validate the test. At the moment, this test simply shows that foo is used for values 0 and 4.


================
Comment at: llvm/test/tools/llvm-nm/ARM/special-syms.test:1
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-nm %t | count 0
----------------
Add a comment to the top of this test explaining what symbols are considered special for ARM.

Do you need an AARCH64 version of this test?


================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:1808
+      // Don't drop format specifc symbols for ARM and AArch64 ELF targets, they
+      // are used to repesent mapping symbols and needed to honor --special-syms
+      // option.
----------------
Also, clang-format the new code below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98803/new/

https://reviews.llvm.org/D98803