[PATCH] D98819: [M68k] Replace unknown operand with explicit type

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 18 20:57:22 PDT 2021


myhsu added a comment.

LGTM after the inlined comment is addressed.



================
Comment at: llvm/lib/Target/M68k/M68kInstrArithmetic.td:548
 
+// This is needed as division only takes a 16-bit immediate.
+def as_i16imm : SDNodeXForm<imm, [{
----------------
Though this is only used by division for now, I would recommend to write a more general description (without mentioning division).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98819/new/

https://reviews.llvm.org/D98819



More information about the llvm-commits mailing list