[PATCH] D98762: [LTO][MC] Discard non-prevailing defined symbols in module-level assembly

Thu Mar 18 12:15:43 PDT 2021

MaskRay added a comment.

In D98762#2635362 <https://reviews.llvm.org/D98762#2635362>, @ychen wrote:

> - Add a test case for .symver
> - Rename test file properly

Oh I missed `EnableLTODiscardSymbols`, which is different in LTO and non-LTO. Isn't it a unneeded implementation detail? You can just let `.lto_discard` prevent definitions.
Yes, the name is a bit misnomer here, but that does not matter if you document clearly that it is an implementation detail of inline asm handling in LTO so that users will not misuse it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98762/new/

https://reviews.llvm.org/D98762