[PATCH] D98762: [LTO][MC] Discard non-prevailing defined symbols in module-level assembly

[Yuanfang Chen via Phabricator via llvm-commits]

ychen marked 3 inline comments as done.
ychen added inline comments.


================
Comment at: llvm/test/MC/ELF/lto-discard.s:3
+// .lto_discard is supposed to only work for inline assembly.
+// RUN: llvm-mc -filetype=asm -triple x86_64-pc-linux-gnu < %s | FileCheck %s
+
----------------
MaskRay wrote:
> `-filetype=asm` does not have effects. You need a `-filetype=obj` test to show that the `foo` definition is ignored.
I'm checking `.lto_discard` is no-op here..

`inline-asm-lto-discard.ll` is beefed up to test this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98762/new/

https://reviews.llvm.org/D98762