[PATCH] D98829: [libomptarget] Add register usage info to kernel metadata

Thu Mar 18 09:51:54 PDT 2021

dhruvachak added a comment.

In D98829#2634094 <https://reviews.llvm.org/D98829#2634094>, @JonChesterfield wrote:

> Looks good to me, thanks.
>
> We should probably use uint64_t everywhere, instead of sometimes truncating to uint32_t, but that pattern and the 0,0,0,0, one are pre-existing.
>
> Let's go with this and report errors on implausible (e.g. > 4 billion) register counts as a separate patch, along with sanity checking requested LDS etc.

Thanks, Jon. I don't have commit access. Can you please land this change?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98829/new/

https://reviews.llvm.org/D98829