[PATCH] D98829: [libomptarget] Add register usage info to kernel metadata
Jon Chesterfield via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 18 03:45:05 PDT 2021
JonChesterfield accepted this revision.
JonChesterfield added a comment.
This revision is now accepted and ready to land.
Looks good to me, thanks.
We should probably use uint64_t everywhere, instead not sometimes truncating to uint32_t, but that pattern and the 0,0,0,0, one are pre-existing.
Let's go with this and report errors on implausible (e.g. > 4 billion) register counts as a separate patch, along with sanity checking requested LDS etc.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98829/new/
https://reviews.llvm.org/D98829
More information about the llvm-commits
mailing list