[PATCH] D98865: [AMDGPU] Disable forceful inline of non-kernel functions which use LDS.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 18 08:09:51 PDT 2021


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAlwaysInlinePass.cpp:120
+  //
+  // Update: Since now LDS uses within non-kernel functions are being handled in
+  // the pass - LowerModuleLDS, we *NO* need to *forcefully* inline non-kernel
----------------
Having "Update" in a comment doesn't make sense. Just explain the current situation


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98865/new/

https://reviews.llvm.org/D98865



More information about the llvm-commits mailing list