[PATCH] D98865: [AMDGPU] Disable forceful inline of non-kernel functions which use LDS.

Mahesha S via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 18 06:51:53 PDT 2021


hsmhsm created this revision.
hsmhsm added reviewers: arsenm, JonChesterfield.
Herald added subscribers: kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl.
hsmhsm requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

Since now, LDS uses within non-kernel functions are being handled in the
pass - `LowerModuleLDS`, we *NO* need to *forcefully* inline non-kernel
functions just because they use LDS. Do forceful inlining only when the
pass - `LowerModuleLDS` is not enabled. It is enabled by default.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D98865

Files:
  llvm/lib/Target/AMDGPU/AMDGPUAlwaysInlinePass.cpp
  llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
  llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.h
  llvm/test/CodeGen/AMDGPU/GlobalISel/lds-global-non-entry-func.ll
  llvm/test/CodeGen/AMDGPU/addrspacecast-initializer-unsupported.ll
  llvm/test/CodeGen/AMDGPU/force-alwaysinline-lds-global-address-codegen.ll
  llvm/test/CodeGen/AMDGPU/force-alwaysinline-lds-global-address.ll
  llvm/test/CodeGen/AMDGPU/lds-global-non-entry-func.ll
  llvm/test/CodeGen/AMDGPU/promote-alloca-to-lds-constantexpr-use.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98865.331551.patch
Type: text/x-patch
Size: 9905 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210318/bc9544e3/attachment.bin>


More information about the llvm-commits mailing list