[PATCH] D97350: [SampleFDO] Another fix to prevent repeated indirect call promotion in sample loader pass

[Wei Mi via llvm-commits]

On Wed, Mar 3, 2021 at 4:18 PM Hongtao Yu via Phabricator <
reviews at reviews.llvm.org> wrote:

> hoy added a comment.
>
> Thank for the fix. I've been seeing an assert failure related to ICP. Do
> you think that can be fixed by this patch?
>
> llvm/lib/Analysis/IndirectCallPromotionAnalysis.cpp:78: uint32_t
> llvm::ICallPromotionAnalysis::getProfitablePromotionCandidates(const
> llvm::Instruction*, uint32_t, uint64_t): Assertion `Count <=
> RemainingCount' failed.
>

I run into a case with the same assertion triggered. Sent out
https://reviews.llvm.org/D98835 to fix it.


>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D97350/new/
>
> https://reviews.llvm.org/D97350
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210317/d9debac2/attachment.html>