<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:times new roman,serif"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Mar 3, 2021 at 4:18 PM Hongtao Yu via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">hoy added a comment.<br>
<br>
Thank for the fix. I've been seeing an assert failure related to ICP. Do you think that can be fixed by this patch?<br>
<br>
llvm/lib/Analysis/IndirectCallPromotionAnalysis.cpp:78: uint32_t llvm::ICallPromotionAnalysis::getProfitablePromotionCandidates(const llvm::Instruction*, uint32_t, uint64_t): Assertion `Count <= RemainingCount' failed.<br></blockquote><div><br></div><div><div class="gmail_default" style="font-family:"times new roman",serif">I run into a case with the same assertion triggered. Sent out <a href="https://reviews.llvm.org/D98835">https://reviews.llvm.org/D98835</a> to fix it.  </div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
Repository:<br>
  rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D97350/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D97350/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D97350" rel="noreferrer" target="_blank">https://reviews.llvm.org/D97350</a><br>
<br>
</blockquote></div></div>