[PATCH] D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF

Wed Mar 17 17:42:37 PDT 2021

shchenz added a comment.

In D97186#2632123 <https://reviews.llvm.org/D97186#2632123>, @echristo wrote:

> In D97186#2631868 <https://reviews.llvm.org/D97186#2631868>, @shchenz wrote:
>
>> Thanks for review @echristo
>>
>>> a) Can you name it something other than empty? Maybe basic or something?
>>
>> Done
>>
>>> b) Reasonable to loosen up the checks slightly? There's a lot of -NEXT in there that doesn't appear to be strictly necessary (unless you're autogenerating the checks - if so let me know).
>>
>> Yeah, sort of auto-generating. But do we need to loosen up the checks? This DWARF info should be settled as the result of the tests comes from object files.
>
> Yeah, it's tough. Right now if anything changes even slightly in the output the test will fail, but isn't necessarily everything you need to be checking if that makes sense? That said, it's probably on the small order of update probability so it's fine if you'd like to leave it this way and we can update it later if it becomes an issue.
>
> Accepting (though fix any other feedback first).
>
> -eric

Yeah. Agree, at least there is no need for the requirement of the DIE attributes' order and the fixed offset in the .dwinfo sections. This will be too tough if we regenerate the object file for every new commit. But for this case, since we directly test the object files, so I think it should be ok. Yeah, we may still have some changes in llvm-dwarfdump tool which makes the output different, but that should be not often.

Thanks for your review

================
Comment at: llvm/test/tools/llvm-dwarfdump/XCOFF/basic.test:7-8
+##
+## basic64.o Compiled with GCC, version 8.3.0
+## Compiler command: xlc basic.c -c -qdbgfmt=dwarf -g -q64 -o basic64.o
+##
----------------
jasonliu wrote:
> The compiler version comment and the compile command is not consistent.
Will update it in the commit. Thanks

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97186/new/

https://reviews.llvm.org/D97186