[PATCH] D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF

Wed Mar 17 10:03:41 PDT 2021

echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

In D97186#2631868 <https://reviews.llvm.org/D97186#2631868>, @shchenz wrote:

> Thanks for review @echristo
>
>> a) Can you name it something other than empty? Maybe basic or something?
>
> Done
>
>> b) Reasonable to loosen up the checks slightly? There's a lot of -NEXT in there that doesn't appear to be strictly necessary (unless you're autogenerating the checks - if so let me know).
>
> Yeah, sort of auto-generating. But do we need to loosen up the checks? This DWARF info should be settled as the result of the tests comes from object files.

Yeah, it's tough. Right now if anything changes even slightly in the output the test will fail, but isn't necessarily everything you need to be checking if that makes sense? That said, it's probably on the small order of update probability so it's fine if you'd like to leave it this way and we can update it later if it becomes an issue.

Accepting (though fix any other feedback first).

-eric

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97186/new/

https://reviews.llvm.org/D97186