[PATCH] D98767: [lit] Harmonize test timing data between Unix and Windows

[David Zarzycki via Phabricator via llvm-commits]

davezarzycki added inline comments.


================
Comment at: llvm/utils/lit/lit/Test.py:265-266
 
-        if os.sep.join(path_in_suite) in suite.test_times:
-            time = suite.test_times[os.sep.join(path_in_suite)]
+        if '/'.join(path_in_suite) in suite.test_times:
+            time = suite.test_times['/'.join(path_in_suite)]
             self.previous_elapsed = abs(time)
----------------
yln wrote:
> Could we use `getFullName()` here?  Or if the config-qualified name is undesirable, we could extract this into `Test::getName()`.
> 
> ```
>     def getFullName(self):
>         return self.suite.config.name + ' :: ' + '/'.join(self.path_in_suite)
> ```
All of the timing data is stored per test suite, so prefixing the suite name in this context doesn't solve anything. As to factoring that out, sure. We can do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98767/new/

https://reviews.llvm.org/D98767