[PATCH] D98767: [lit] Harmonize test timing data between Unix and Windows
Julian Lettner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 17 11:09:46 PDT 2021
yln added inline comments.
================
Comment at: llvm/utils/lit/lit/Test.py:265-266
- if os.sep.join(path_in_suite) in suite.test_times:
- time = suite.test_times[os.sep.join(path_in_suite)]
+ if '/'.join(path_in_suite) in suite.test_times:
+ time = suite.test_times['/'.join(path_in_suite)]
self.previous_elapsed = abs(time)
----------------
Could we use `getFullName()` here? Or if the config-qualified name is undesirable, we could extract this into `Test::getName()`.
```
def getFullName(self):
return self.suite.config.name + ' :: ' + '/'.join(self.path_in_suite)
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98767/new/
https://reviews.llvm.org/D98767
More information about the llvm-commits
mailing list