[PATCH] D98801: [NFC][RISCV] Wrong stack slot for GPR and RVV spilled registers

Roger Ferrer Ibanez via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 17 11:37:27 PDT 2021


rogfer01 created this revision.
rogfer01 added reviewers: StephenFan, HsiangKai, craig.topper.
Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, asb.
rogfer01 requested review of this revision.
Herald added subscribers: llvm-commits, MaskRay.
Herald added a project: LLVM.

This testcase shows that we attempt to assign the same offset `sp + 16` to two different stack objects.

The fix will come in a later change.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D98801

Files:
  llvm/test/CodeGen/RISCV/rvv/wrong-stack-slot.mir


Index: llvm/test/CodeGen/RISCV/rvv/wrong-stack-slot.mir
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/RISCV/rvv/wrong-stack-slot.mir
@@ -0,0 +1,68 @@
+# RUN: llc -mtriple=riscv64 -mattr=+m,+experimental-v  -o - %s \
+# RUN:   -start-before=prologepilog | FileCheck %s
+--- |
+  define void @foo()
+  {
+  entry:
+    ret void
+  }
+...
+---
+name:            foo
+alignment:       2
+exposesReturnsTwice: false
+legalized:       false
+regBankSelected: false
+selected:        false
+failedISel:      false
+tracksRegLiveness: true
+hasWinCFI:       false
+registers:       []
+liveins:
+  - { reg: '$x10', virtual-reg: '' }
+frameInfo:
+  isFrameAddressTaken: false
+  isReturnAddressTaken: false
+  hasStackMap:     false
+  hasPatchPoint:   false
+  stackSize:       0
+  offsetAdjustment: 0
+  maxAlignment:    8
+  adjustsStack:    false
+  hasCalls:        true
+  stackProtector:  ''
+  maxCallFrameSize: 4294967295
+  cvBytesOfCalleeSavedRegisters: 0
+  hasOpaqueSPAdjustment: false
+  hasVAStart:      false
+  hasMustTailInVarArgFunc: false
+  localFrameSize:  0
+  savePoint:       ''
+  restorePoint:    ''
+fixedStack:      []
+stack:
+  - { id: 0, name: '', type: spill-slot, offset: 0, size: 8, alignment: 8,
+      stack-id: default, callee-saved-register: '', callee-saved-restored: true,
+      debug-info-variable: '', debug-info-expression: '', debug-info-location: '' }
+  - { id: 1, name: '', type: spill-slot, offset: 0, size: 16, alignment: 8,
+      stack-id: scalable-vector, callee-saved-register: '', callee-saved-restored: true,
+      debug-info-variable: '', debug-info-expression: '', debug-info-location: '' }
+callSites:       []
+debugValueSubstitutions: []
+constants:       []
+machineFunctionInfo: {}
+body:             |
+  bb.0.entry:
+    ; CHECK-LABEL: foo:
+    ; CHECK:    sd a0, 16(sp)
+    ; CHECK-NEXT:    addi a0, sp, 16
+    ; CHECK-NEXT:    vs2r.v v30, (a0)
+    liveins: $x10, $v30m2
+
+    $x25 = COPY $x10
+    SD renamable $x25, %stack.0, 0 :: (store 8 into %stack.0)
+    PseudoVSPILL_M2 renamable $v30m2, %stack.1 :: (store unknown-size into %stack.1, align 8)
+    PseudoRET
+
+...
+


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98801.331332.patch
Type: text/x-patch
Size: 2199 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210317/5a596e52/attachment.bin>


More information about the llvm-commits mailing list