[PATCH] D98762: [LTO][MC] Discard non-prevailing defined symbols in module-level assembly

Wed Mar 17 11:14:47 PDT 2021

ychen added a comment.

In D98762#2630923 <https://reviews.llvm.org/D98762#2630923>, @MaskRay wrote:

> Alternatively, you can make `.lto_discard` reset the symbol list, then `.lto_discard` is sufficient and `.module` will not be needed.

Thanks for the review. Yeah, if we keep the ".lto_discard" then ".module" is not needed. In that case, it has to be legal to use ".lto_discard" without trailing symbols since a marker is still needed to separate the inlineasm block for each module. Otherwise, asm symbols in an irrelevant module could be discarded incorrectly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98762/new/

https://reviews.llvm.org/D98762