[PATCH] D98762: [LTO][MC] Discard non-prevailing defined symbols in module-level assembly

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/MC/MCParser/AsmParser.cpp:1894
 
+    if (discardLTOSymbol(IDVal))
+      return false;
----------------
ychen wrote:
> MaskRay wrote:
> > Needs a test/MC/ELF test that reassignment does not error.
> Something like `llvm/test/MC/AsmParser/reassign.s` for this patch?
Yes.

What do you think of dropping `.lto_module`? One directive `.lto_discard` is enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98762/new/

https://reviews.llvm.org/D98762