[PATCH] D98501: [RISCV] Update RVV shift intrinsic tests to use XLEN bit as shift amount.

Zakk Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 17 07:11:03 PDT 2021


khchen added a comment.

In D98501#2622189 <https://reviews.llvm.org/D98501#2622189>, @frasercrmck wrote:

> I can see that the shift amount should be XLen, but is there a crash that this fixes? Or is it that it shouldn't be possible to generate these intrinsics in the first place? I'm wondering what (if anything) can be put in place to stop this from happening again.

I think it's shouldn't be generated and we noted them when we start working on supporting rvv intrinsics.

Maybe we could define the explicitly type for vector/vector and vector/scalar in the IR intrinsic, it would make intrinsics more strongly typed.
But personally I prefer to keep current intrinsic design...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98501/new/

https://reviews.llvm.org/D98501



More information about the llvm-commits mailing list